Align upload limits with new MEDIA_MAX_UPLOAD_SIZE_MB app cap#38
Merged
Conversation
Upstream display-api-service 3.0.0 introduces a Symfony-level upload ceiling (MEDIA_MAX_UPLOAD_SIZE_MB, default 200 MiB) enforced on Media::$file. The cap flows into .env.symfony automatically via task env:init, but the PHP and nginx example defaults shipped here (128M / 140M / 140m) were below it — large uploads would have been rejected at the proxy/PHP layer with an opaque 413 instead of the app's clear validator error. Bumps PHP_UPLOAD_MAX_FILESIZE to 200M, PHP_POST_MAX_SIZE to 210M, and NGINX_MAX_BODY_SIZE to 210m so the four-layer inequality holds out of the box. UPGRADE.md gets a new sub-section spelling out the alignment rule and an env:diff verification step for operators whose migrated .env.symfony predates the new var. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream PR os2display/display-api-service#458
(merged into upstream
release/3.0.0on 2026-05-26, issue#392) introduced a new
Symfony-level upload ceiling:
MEDIA_MAX_UPLOAD_SIZE_MB(default 200 MiB), enforced by
MediaFileValidatoronMedia::$file.The cap flows into
.env.symfonyautomatically viatask env:init(which extracts theupstream
/app/.env), but the PHP and nginx example defaults shipped here (128M/140M/140m) were below it — large uploads would have been rejected at the proxy /PHP layer with an opaque 413 instead of the app's clear validator error message.
.env.php.example:PHP_UPLOAD_MAX_FILESIZE128M → 200M,PHP_POST_MAX_SIZE140M → 210M..env.nginx.example:NGINX_MAX_BODY_SIZE140m → 210m.MEDIA_MAX_UPLOAD_SIZE_MBceiling.inequality (
NGINX_MAX_BODY_SIZE >= PHP_POST_MAX_SIZE >= PHP_UPLOAD_MAX_FILESIZE >= MEDIA_MAX_UPLOAD_SIZE_MB)and gives operators an
env:diffstep to catch a migrated.env.symfonythat predates the new var.Test plan
task env:initon this branch writesPHP_UPLOAD_MAX_FILESIZE=200M,PHP_POST_MAX_SIZE=210M,NGINX_MAX_BODY_SIZE=210minto the per-service env files.task installsucceeds, all serviceshealthy.MEDIA_MAX_UPLOAD_SIZE_MB, not a generic 413.task env:diffagainst the upstream image produces no spurious diff on the upload-related keys.🤖 Generated with Claude Code